Skip to content

feat: add ERC-20 approval race + low-level call checks#61

Open
wndzph9jkb-create wants to merge 1 commit into
kcolbchain:mainfrom
wndzph9jkb-create:kcolb/erc20-approval-race-low-level-call
Open

feat: add ERC-20 approval race + low-level call checks#61
wndzph9jkb-create wants to merge 1 commit into
kcolbchain:mainfrom
wndzph9jkb-create:kcolb/erc20-approval-race-low-level-call

Conversation

@wndzph9jkb-create

Copy link
Copy Markdown

Closes #35, #36, #37

Adds:

  • ERC20ApprovalRaceCheck.sol + test + examples (detects race conditions in ERC-20 approve patterns)
  • LowLevelCallCheck.sol + test + examples (detects unsafe low-level call patterns)
  • Corresponding Slither detectors for automated analysis

@abhicris

Copy link
Copy Markdown
Contributor

Welcome to kcolbchain, @wndzph9jkb-create — glad you're here. 🌱

Here's what happens from this PR:

  1. Our automated review looks for obvious issues (tests, secrets, size) within a couple of hours.
  2. If it's clean and CI passes, we merge without back-and-forth.
  3. If we need changes, we'll leave a specific comment — not a generic nit. Push another commit and we re-review.

While you wait:

  • Run the repo's tests locally (see the repo README.md).
  • Keep the PR scoped to one concern — bigger PRs land slower.
  • Don't commit tokens or .env contents.

What happens after your first merge

Thanks for writing the code. We're building this to last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

L0: Verify audit suite builds + runs locally, fix any setup friction

2 participants