-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add example highlight hover content for the schema definition doc #1828
base: main
Are you sure you want to change the base?
Conversation
… test Signed-off-by: Your Name <[email protected]>
@Peefy When I run
Even after running the tests on the branch with my changes, these tests are still failing, and the new test I added also fails. Could this be an issue with my setup, or is there another reason for these failures? Any guidance would be greatly appreciated! |
which your cargo and rust version |
Rust version: |
@He1pa @Peefy @zong-zhe
I looked at the CI's output for the failed test and added the missing Examples doc to the test and still got the same output I attached above. |
Signed-off-by: Siddhi Agrawal <[email protected]>
Hello @Siddhi-agg This is a git submodule. You can update the submodule to get test cases. |
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix [Enhancement] Add example highlight hover content for the schema definition doc. #1469
2. What is the scope of this PR (e.g. component or file name):
kcl/kclvm/tools/src/LSP/src/hover.rs
kcl/kclvm/tools/src/LSP/src/test_data/hover_test/schema_with_examples.k
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: