Feedback#1
Open
github-classroom[bot] wants to merge 30 commits into
Open
Conversation
* add draft of project charter * update project charter * latest updates * add driving and idle time to requirements --------- Co-authored-by: Suheyla Keskin <ksknshyl@gmail.com>
* cleanup READMEs * add project logo
* Update README.md * Update README.md * Update README.md * video stream video stream on computer side with python code and opencv * script on rpi script on rpi that will run libcamera-vid ( which is the command to stream) all the time, and will not close connection after user close app on client side * server basic server that recive data sent by client and showing what the client send ( later to improve that it will have command handler ) * basic client basic client side of the communication. App can run stream and sending commands :))))) POZDRO KUBA PATRZ JAK TATA JEST WIELKI * Update client.py I added the info about how to steer and right now commands can be send all the time to the server * Update server.py Handling reciving commands all the time from the client side, also sending commands forward to the uart port. * Update client.py * Update client.py * Update client.py --------- Co-authored-by: Jakub Kaszowski <jakub.kaszowski@outlook.com>
* add stm32 project * Remove Debug/ * fixes
added exceptions handling and local variables
Co-authored-by: Paweł Rak <264355@student.pwr.edu.pl>
* Update client.py * Update client.py * Update client.py * Update README.md * Add files via upload * Update client.py * Update client.py
* Motors first try * fixes * Remove drivers and update .ioc
* Fix handling keys In some cases (when camera is not connected), the code fails on self.cap.read() and does not send commands on keypress * Fix commands format Force all numbers sent to be integers
* Motors first try * fixes * Remove drivers and update .ioc * Add template for servos * Add servos to .ioc * Update .gitignore * Add unit tests and parsing for servos * Update README
* new YOLO detection * Names of objects (#1) * fixing opencv in client.py add code from the branch Ryan-Fixed * some fixes * Configuration Files --------- Co-authored-by: ryanWh00 <269580@student.pwr.edu.pl> Co-authored-by: Mikołaj Pastucha <67973699+Pastucha@users.noreply.github.com>
* Add low level software section draft * Add Mikolaj's part
* Add final version of the report * Remove old report template * remove unused pdf * Cleanup
* try to fix opencv * inversion of text in bounding box * Update client.py * Update stream.sh --------- Co-authored-by: ryanWh00 <99709108+ryanWh00@users.noreply.github.com>
|
Proposed grade: 5.0 Issues:
Other (remarks for future):
|
* Add system overview section * Add missing pdf
|
Corrections accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @jkaszowski @ryanWh00 @suheylakeskin @Zip-Lip @Pastucha