Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile w/ gradle build & add compose file #16

Merged
merged 1 commit into from
May 3, 2024

Conversation

MrCreosote
Copy link
Member

Remove old build cruft

@MrCreosote MrCreosote requested a review from Xiangs18 May 1, 2024 18:35
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.06%. Comparing base (5a91b7d) to head (8986759).
Report is 4 commits behind head on develop.

Files Patch % Lines
...n/java/us/kbase/userprofile/UserProfileServer.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #16      +/-   ##
=============================================
- Coverage      51.70%   51.06%   -0.65%     
  Complexity        61       61              
=============================================
  Files              7        7              
  Lines            381      376       -5     
  Branches          55       53       -2     
=============================================
- Hits             197      192       -5     
  Misses           147      147              
  Partials          37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiangs18
Copy link
Collaborator

Xiangs18 commented May 3, 2024

Could you please explain more where the following 2 files are used?
deployment/conf/.templates/deployment.cfg.templ
deployment/conf/example.ini

@MrCreosote
Copy link
Member Author

For deployment.cfg.example, it's just an example file to use if you want to run the server locally, similar to https://github.com/kbase/workspace_deluxe/blob/develop/deploy.cfg.example

I'm not entirely sure about example.ini - this is the first time I've seen this setup, but it looks like you could use it to provide environment values for your templates:

CMD [ "-env", "/kb/deployment/conf/example.ini", \

We don't do that in the docker compose file and I'm guessing we probably don't do that in rancher either

@MrCreosote MrCreosote merged commit 5842f5b into develop May 3, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants