Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for dts-flavored bulk_specification endpoint #214

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

briehl
Copy link
Member

@briehl briehl commented Dec 19, 2024

As the title says. This just updates the relevant READMEs.

Comment on lines +4 to +6
import specifications. These should be referenced by deployment and testing configuration
as necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. now I think about it, I wanted to delete the import_specifications folder as it was no longer needed since the narrative generates them on the fly. They were a stop gap up until that point.

See #178

Does it make sense for the schemas to live here or somewhere with a better name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the rest of the folder is going away, I don't see a reason not to move schemas to something like "import_specification_schemas" or something like that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might still make sense to have a template or some user-facing (or dev-facing) documentation for using the XSV/Excel importer specifications, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the rest of the folder is going away, I don't see a reason not to move schemas to something like "import_specification_schemas" or something like that.

I'd probably call it "import_schemas" to disambiguate from the import specification system

It might still make sense to have a template or some user-facing (or dev-facing) documentation for using the XSV/Excel importer specifications, though.

There's this: https://docs.kbase.us/data/upload-download-guide/bulk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants