Adjust file mappings #213
Open
Adjust file mappings #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briehl
commented
Dec 19, 2024
There was a problem hiding this comment.
Autogenerated file. See the other two for real details.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early in the DTS development, we mapped JSON files to the bulk import spec manager. Later, we decided that bulk import specs as JSON files could have multiple formats in the future. While the currently developed DTS manifest.json files do use the
import_specificationendpoint, just giving the front end the "import specification" mapping isn't enough information to properly form the request.Therefore, this change removes the JSON mapping from
import_specificationand moves it to the newdts_manifest, which is more clear for both the front end consumer and the user.