-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dts-manifest-schema changes into develop #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTS Manifest parsing
Quality Gate passedIssues Measures |
briehl
changed the title
Merge DTS manifest schema changes into develop
Merge dts-manifest-schema changes into develop
Dec 17, 2024
MrCreosote
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved all this already as per the OP, so rubber stamping
Deleting my intermediate branches so this nonsense doesn't happen again :\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the feature branch that the latest batch of DTS manifest work has been on, getting merged up.
The previous PR #210 merged from
dts-manifest-parse
todts-manifest-schema
instead of todevelop
like it was supposed to, once the previous PR fromdts-manifest-schema
was merged.Anyway, this is all code that was previously reviewed in #210, with a minor change to a path in the config file in #211.