Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dts-manifest-schema changes into develop #212

Merged
merged 13 commits into from
Dec 17, 2024
Merged

Conversation

briehl
Copy link
Member

@briehl briehl commented Dec 17, 2024

This is basically the feature branch that the latest batch of DTS manifest work has been on, getting merged up.

The previous PR #210 merged from dts-manifest-parse to dts-manifest-schema instead of to develop like it was supposed to, once the previous PR from dts-manifest-schema was merged.

Anyway, this is all code that was previously reviewed in #210, with a minor change to a path in the config file in #211.

@briehl briehl changed the title Merge DTS manifest schema changes into develop Merge dts-manifest-schema changes into develop Dec 17, 2024
@briehl briehl requested a review from MrCreosote December 17, 2024 20:04
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved all this already as per the OP, so rubber stamping

@briehl briehl merged commit aa24fff into develop Dec 17, 2024
11 checks passed
@briehl briehl deleted the dts-manifest-schema branch December 17, 2024 20:11
@briehl
Copy link
Member Author

briehl commented Dec 17, 2024

Deleting my intermediate branches so this nonsense doesn't happen again :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants