Merge pull request #436 from kbase/dev-compile_for_java8

Compile for java 8
kbase · Apr 11, 2024 · 5a8528c · 5a8528c
2 parents 910bad7 + e9eb306
commit 5a8528c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -58,4 +58,5 @@ jobs:
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3
         with:
+          token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: true
diff --git a/build.gradle b/build.gradle
@@ -26,13 +26,9 @@ task buildGitCommitFile {
 }
 
 compileJava {
-	if (JavaVersion.current() <= JavaVersion.VERSION_1_8) {
-		// TODO BUILD remove when we no longer support java 8
-		java.sourceCompatibility = JavaVersion.VERSION_1_8
-		java.targetCompatibility = JavaVersion.VERSION_1_8
-	} else {
-		options.release = 8
-	}
+	// TODO BUILD remove when we no longer support java 8, use `options.release = 11` if needed
+	java.sourceCompatibility = JavaVersion.VERSION_1_8
+	java.targetCompatibility = JavaVersion.VERSION_1_8
 	finalizedBy buildGitCommitFile
 }