-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Callback module #50
base: main
Are you sure you want to change the base?
Conversation
This refactors the configuration handling to use a class instead of a dict. So this is a large change because this weaves through out the platform. There are a few minor flake8 fixes too but this is primarily what is needed to make the configuration change and fix tests.
Also fixed an error in the JobRunner init
This adds the ability to pass in the provenenace initialization when using the callback module. This is done by setting "PROV_FILE" to a file name that has a valid json structure.
…nto scanon/refactor_config
This adds actions for running tests and building and pushing a docker image to ghcr.
Co-authored-by: MrCreosote <[email protected]>
Co-authored-by: MrCreosote <[email protected]>
Co-authored-by: MrCreosote <[email protected]>
…nto scanon/refactor_config
Refactor Configuration Handling
Add github actions and fix tests
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage ? 75.18%
=======================================
Files ? 13
Lines ? 1068
Branches ? 0
=======================================
Hits ? 803
Misses ? 265
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This fixes up some issues with the merge and gets tests passing with the new Sanic.
…into callback_module
Update to sanic 21.12.2
We are still iterating on this a bit but let's get it ready to merge.