Add iterative tests #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
After this change:
I think the new ops are valid, just different from the expected ones becase we are using diff-match-patch. |
curran
commented
Nov 29, 2021
| @@ -10,7 +10,7 @@ let textUnicode = require("ot-text-unicode"); | |||
| var jsondiff = require("./index.js"); | |||
|
|
|||
| var tests = [ | |||
| //tests of equality | |||
| // Tests of equality | |||
There was a problem hiding this comment.
Thanks! It might be nice to adopt Prettier so these things don't come up in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some downstream development work, I became suspicious that there might be some bug in the string support with JSON1. So I double checked all the tests here to make sure everything was covered. I noticed several issues with the tests and fixed them here in this PR.
tests.js, the input was being mutated by json0, so the json1 tests were actually all just getting the same object as input and as output. This PR fixes that.I'm happy to report that all of the tests do in fact pass, and no bug in the implementation was found.