Skip to content

Refactor frequency assertion for improved performance #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasckng wants to merge 3 commits into from
Closed

Refactor frequency assertion for improved performance #244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d50465
Refactor frequency assertion checks to use jnp.allclose for improved …
thomasckng Jul 28, 2025
222aa6e
Replace jnp.allclose with jnp.array_equal for frequency assertions in…
thomasckng Jul 28, 2025
459ff23
Replace allclose with arrayequal for frequencies check
SSL32081 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/jimgw/core/single_event/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,11 @@ def from_fd(
# This ensures the newly constructed Data in FD fully
# represents the input FD data.
d_new, f_new = data.frequency_slice(frequencies[0], frequencies[-1])
assert all(jnp.equal(d_new, fd)), "Data do not match after slicing"
assert all(
jnp.equal(f_new, frequencies)
assert jnp.allclose(
d_new, fd, rtol=1e-10, atol=1e-15
), "Data do not match after slicing"
assert jnp.allclose(
f_new, frequencies, rtol=1e-10, atol=1e-15
), "Frequencies do not match after slicing"
return data

Expand Down
4 changes: 2 additions & 2 deletions src/jimgw/core/single_event/detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ def set_frequency_bounds(
data, freqs_1 = self.data.frequency_slice(*self.frequency_bounds)
psd, freqs_2 = self.psd.frequency_slice(*self.frequency_bounds)

assert all(
freqs_1 == freqs_2
assert jnp.allclose(
Comment thread
thomasckng marked this conversation as resolved.
Outdated
freqs_1, freqs_2, rtol=1e-10, atol=1e-15
), f"The {self.name} data and PSD must have same frequencies"

self._sliced_frequencies = freqs_1
Expand Down
Loading