Skip to content

fix get_sql in AliasedQuery #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tigerfsh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix get_sql in AliasedQuery #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
exclude: '.git'
default_stages: [commit]
default_stages: [pre-commit]
fail_fast: false

repos:
Expand Down
10 changes: 9 additions & 1 deletion pypika/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,16 @@ def __init__(self, name: str, query: Optional[Selectable] = None) -> None:
self.query = query

def get_sql(self, **kwargs: Any) -> str:
with_alias = kwargs.pop("with_alias", False)
quote_char = kwargs.pop("quote_char", None)

query_sql = format_quotes(self.name, quote_char)
query_alias = getattr(self, 'alias', None)

if self.query is None:
return self.name
if with_alias:
return format_alias_sql(query_sql, query_alias, quote_char=quote_char, **kwargs)
return query_sql
return self.query.get_sql(**kwargs)

def __eq__(self, other: "AliasedQuery") -> bool:
Expand Down