Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edits to add discrete or continuous #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SwampThingPaul
Copy link

Hi Katie, Love your package!! I just added an ability to make the color palette discrete (like your base package) or continuous. Thanks again. You don't have to "accept" the changes if you don't want to.

@katiejolly
Copy link
Owner

Thanks for submitting a pull request! I'm not going to merge quite yet. A few thoughts:

  • for the hex sticker, the package isn't actually affiliated with NPS so I don't want to use their logo
  • for the continuous scales, my only hesitation is that I want to be able to sort colors before making them continuous, so maybe I'll look into that a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants