Merge pull request #116 from kasecato/#113/arrayParams

#113/array params
kasecato · Nov 14, 2020 · 1277cb9 · 1277cb9
2 parents f0dc311 + 79c2794
commit 1277cb9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,13 @@
 # Change Log
 
+## 0.1.19 (Nov 14, 2020)
+
+* bug fix - Type is detected as parameter. See [#113](https://github.com/kasecato/vscode-docomment/issues/113).
+* upgrade libs
+
 ## 0.1.18 (Aug 12, 2020)
 
-* enhancement - add support for Blazor .razor files. See [#110](https://github.com/kasecato/vscode-docomment/issues/110)
+* enhancement - add support for Blazor .razor files. See [#110](https://github.com/kasecato/vscode-docomment/issues/110).
 * upgrade libs
 
 ## 0.1.17 (July 28, 2020)

diff --git a/src/Domain/Lang/DocommentDomainCSharp.ts b/src/Domain/Lang/DocommentDomainCSharp.ts
@@ -189,7 +189,7 @@ export class DocommentDomainCSharp extends DocommentDomain {
             case CodeType.Method:
                 genericList = SyntacticAnalysisCSharp.GetGenericMethodsList(code);
                 paramNameList = SyntacticAnalysisCSharp.GetMethodParamNameList(code);
-                hasReturn = SyntacticAnalysisCSharp.HasMethodReturn(code);
+                    hasReturn = SyntacticAnalysisCSharp.HasMethodReturn(code);
                 break;
             case CodeType.Field:
                 break;

diff --git a/src/SyntacticAnalysis/SyntacticAnalysisCSharp.ts b/src/SyntacticAnalysis/SyntacticAnalysisCSharp.ts
@@ -198,7 +198,8 @@ export class SyntacticAnalysisCSharp {
         const removedAttrCode: string = code.replace(/^\s*\[.+?\]/, '');       // FIXME:
         const removedExtendsCode: string = removedAttrCode.replace(/:.+/, ''); // FIXME:
         const removedLamdaCode: string = removedExtendsCode.replace(/=>.*/, ''); // FIXME:
-        const params: RegExpMatchArray = removedLamdaCode.match(/.+\(([^)]*)\)/);
+        const removedArrayCode: string = removedLamdaCode.replace(/\[.*?\]/g, ''); // FIXME:
+        const params: RegExpMatchArray = removedArrayCode.match(/.+\(([^)]*)\)/);
 
         const isMatched = (params === null || params.length !== 2);
         if (isMatched) return null;

diff --git a/test/TestData/X.cs b/test/TestData/X.cs
@@ -88,6 +88,8 @@ public static (object result, string name) ComplexFunctionSignatureTwo() { }
     public bool Has(IList<int> a, int b) => a.Any(x => x == b);
     public bool DoesntHas(IList<int> a, int b) => a.Any(x => x != b);
     public IEnumerable<int> ZipAdd(IList<int> a, IList<int> b) => a.Zip(b, (s, t) => s + t);
+
+    private void CSVStringToIntArray( ref string[] pCSVData, ref int[,] pZone) { }
 }
 
 namespace ns {