Add RoPE positional encoding - llama3 feature branch #756
+142
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented RoPE - rotary position embedding from the RoFormer paper.
Note:
wpe
) as that would require touching many parts of the codebase that rely on the particular order inside the parameter buffer (e.g.wpe
has index 1).wpe
buffer.The explicit tradeoff is: suffer a minimal memory bloat (
maxT * C
) but the PR has minimal impact on the readability of the codebase.Tests:
I ran an A/B experiment: trained a 124M GPT-2 on 10B tokens (FineWeb subset) with:
a) learnable positional embeddings (default,
-er
== 0)b) RoPE (
-er
== 1)c) no positional embedding at all
all other settings being the same same.
Results:
Conclusions: