Merge pull request #639 from rosslwheeler/bug_fixes/windows_clean_up

Add unistd.h to fix Windows cuDNN build
karpathy · Jun 25, 2024 · 1f49cc1 · 1f49cc1
2 parents be7a278 + 53985a7
commit 1f49cc1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/dev/unistd.h b/dev/unistd.h
@@ -4,6 +4,7 @@
 
 #define _CRT_SECURE_NO_WARNINGS
 #define _USE_MATH_DEFINES
+#define WIN32_LEAN_AND_MEAN
 
 #include <stdio.h>
 #include <math.h>

diff --git a/llmc/utils.h b/llmc/utils.h
@@ -7,6 +7,7 @@
 #ifndef UTILS_H
 #define UTILS_H
 
+#include <unistd.h>
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>

diff --git a/train_gpt2.cu b/train_gpt2.cu
@@ -1,11 +1,6 @@
 /*
 GPT-2 Transformer Neural Net training loop. See README.md for usage.
 */
-
-#ifdef _WIN32
-#define WIN32_LEAN_AND_MEAN
-#endif
-
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>