Skip to content

fix NaN loss not caught by fast-fail check #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karpathy merged 2 commits into from
Mar 11, 2026
+3 −2
Merged

fix NaN loss not caught by fast-fail check #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ba8ac
fix NaN loss not caught by fast-fail check
haosenwang1018 Mar 9, 2026
ebf3578
fix(train): make NaN fast-fail check explicit
Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
os.environ["HF_HUB_DISABLE_PROGRESS_BARS"] = "1"

import gc
import math
import time
from dataclasses import dataclass, asdict

Expand Down Expand Up @@ -565,8 +566,8 @@ def get_weight_decay(progress):

train_loss_f = train_loss.item()

# Fast fail: abort if loss is exploding
if train_loss_f > 100:
# Fast fail: abort if loss is exploding or NaN
if math.isnan(train_loss_f) or train_loss_f > 100:
print("FAIL")
exit(1)

Expand Down