Harden cache artifact trust boundary in prepare.py#145
Open
Xingkai98 wants to merge 1 commit intokarpathy:masterfrom
Open
Harden cache artifact trust boundary in prepare.py#145Xingkai98 wants to merge 1 commit intokarpathy:masterfrom
Xingkai98 wants to merge 1 commit intokarpathy:masterfrom
Conversation
Fixes karpathy#41 - Add SHA-256 hash verification for tokenizer.pkl and token_bytes.pt - Store hashes in metadata.json for integrity checking - Use torch.load with weights_only=True for safer loading - Raise clear error messages when integrity check fails - Suggest re-running prepare.py if cache is corrupted This prevents loading tampered or corrupted cache artifacts on shared machines or copied cache directories.
IgorTavcar
added a commit
to IgorTavcar/autoresearch
that referenced
this pull request
Mar 11, 2026
Add SHA-256 hash verification for tokenizer.pkl and token_bytes.pt, and use weights_only=True for safer torch.load. Cherry-picked from karpathy#145 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
This prevents loading tampered or corrupted cache artifacts on shared machines or copied cache directories.