Skip to content

Comments

Assignment 1#1

Open
karennh21 wants to merge 2 commits intomainfrom
assignment-1
Open

Assignment 1#1
karennh21 wants to merge 2 commits intomainfrom
assignment-1

Conversation

@karennh21
Copy link
Owner

PULL REQUEST TITLE: UofT-DSI | Sampling - Assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Add code to run the simulation of events 10 and 100 times.
Add code (np.random.seed()) to make the code reproducible.

What did you learn from the changes you have made?

Reproducibility varies based on the number of simulations. The higher the number of simulations, the more reproducible the sample is.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

N/A

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Determining whether or not some parts of the code demonstrated sampling such as the secondary contact tracing function. I reviewed the lecture slides and examples to determine characteristics to look for in sampling and sampling methods which helped overcome the challenges.

How were these changes tested?

I ran the code and plotted the histograms multiple times to analyze the effects on reproducibility.

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • I can confirm that my changes are working as intended

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1:Complete! Suggested changes:

⚠️1. Also Include the Setup stage, ie pd.DataFrame
✅ Good description of each Stage.
✅ Good Takeaway about the simulations with 10 and 100.

✅ Simulation is Reproducible.
Vishakh Patel[LS]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants