feat(sdk): explorer URL builder helpers and unit tests - #227
Open
emarc99 wants to merge 3 commits into
Open
Conversation
|
@emarc99 is attempting to deploy a commit to the karagoz's projects Team on Vercel. A member of the Team first needs to authorize it. |
emarc99
marked this pull request as draft
July 30, 2026 12:53
Author
|
@karagozemin kindly review whenever possible. |
emarc99
marked this pull request as ready for review
July 30, 2026 12:55
emarc99
marked this pull request as draft
July 30, 2026 12:55
|
@emarc99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
emarc99
marked this pull request as ready for review
August 1, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Centralized block explorer URL builders in
@oversync/sdkundersrc/explorers/index.tsand added comprehensive unit test coverage for Sepolia Etherscan and StellarExpert Testnet URLs, as well as placeholder handling for mainnet/public networks.Adds the missing
stellarAccountUrlhelper alongsideethereumTxUrl,ethereumAddressUrl,stellarTxUrl, andstellarContractUrl. Includes robustisValidInputvalidation so empty, whitespace, null, or undefined inputs safely returnnullinstead of generating malformed links.Touched surface
frontend/— React + Vite bridge UIpackages/sdk/— shared TypeScript SDKcoordinator/— order book + REST/WS serviceresolver/— community resolver runnerrelayer/— legacy v1 listener / watchdog (changes here need extra scrutiny)contracts/— Solidity v2 (HTLCEscrow,ResolverRegistry)soroban/— Stellar Soroban contracts (oversync-htlc,oversync-resolver-registry)docs/— documentation only.github/workflows/,docker,env.example)Settlement & refund semantics
Tests run
pnpm --filter @oversync/sdk build && pnpm --filter @oversync/sdk exec tsc --noEmitpnpm --filter @oversync/sdk testpnpm --filter @oversync/coordinator exec tsc --noEmit && pnpm --filter @oversync/coordinator testpnpm --filter @oversync/resolver exec tsc --noEmit && pnpm --filter @oversync/resolver testpnpm --filter @oversync/frontend exec tsc --noEmit && pnpm --filter @oversync/frontend testpnpm --filter @oversync/contracts compile && pnpm --filter @oversync/contracts exec hardhat test test/v2/HTLCEscrow.test.ts test/v2/ResolverRegistry.test.tscd soroban && stellar contract build && cargo test --release(cd contracts && forge test --match-path "test/foundry/*" -v)(Solidity fuzz / invariant)pnpm test:e2e(cross-chain differential harness)node scripts/verify-addresses.mjs— required if addresses, configs, orenv.examplechangenode scripts/check-evidence-links.mjs— advisory; required if docs links changeFree-form outcome:
UI / evidence artefacts
curlsnippet + JSON response sample pasted belowdocs/examples/metrics-snapshot.example.json(or new JSON in PR)Secrets, logging, and PII risk
.envcontent, wallet mnemonics, or preimages added to the repoconsole.*/logger.*line that prints secrets, preimages, signed payloads, or PIIVITE_*andesbuild.droppolicy still holds)Public proof links (SCF / investor evidence)
n/a
Breaking change & rollback
Reviewer checklist (for the PR author to self-verify)
git revertrestores prior state