Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary error return type after using log.Fatalf() #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove unnecessary error return type after using log.Fatalf() #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package main

import (
"log"
"os"

// application
Expand All @@ -14,15 +13,10 @@ import (
)

func main() {
var err error

dbaseDriver := os.Getenv("DB_DRIVER")
dsourceName := os.Getenv("DS_NAME")

dbAdapter, err := db.NewAdapter(dbaseDriver, dsourceName)
if err != nil {
log.Fatalf("failed to initiate dbase connection: %v", err)
}
dbAdapter := db.NewAdapter(dbaseDriver, dsourceName)
defer dbAdapter.CloseDbConnection()

// core
Expand Down
6 changes: 1 addition & 5 deletions internal/adapters/framework/left/grpc/rpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,13 @@ const bufSize = 1024 * 1024
var lis *bufconn.Listener

func init() {
var err error
lis = bufconn.Listen(bufSize)
grpcServer := grpc.NewServer()

dbaseDriver := os.Getenv("DB_DRIVER")
dsourceName := os.Getenv("DS_NAME")

dbAdapter, err := db.NewAdapter(dbaseDriver, dsourceName)
if err != nil {
log.Fatalf("failed to initiate dbase connection: %v", err)
}
dbAdapter := db.NewAdapter(dbaseDriver, dsourceName)

// core
core := arithmetic.New()
Expand Down
4 changes: 2 additions & 2 deletions internal/adapters/framework/right/db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type Adapter struct {
}

// NewAdapter creates a new Adapter
func NewAdapter(driverName, dataSourceName string) (*Adapter, error) {
func NewAdapter(driverName, dataSourceName string) *Adapter {
// connect
db, err := sql.Open(driverName, dataSourceName)
if err != nil {
Expand All @@ -29,7 +29,7 @@ func NewAdapter(driverName, dataSourceName string) (*Adapter, error) {
log.Fatalf("db ping failure: %v", err)
}

return &Adapter{db: db}, nil
return &Adapter{db: db}
}

// CloseDbConnection closes the db connection
Expand Down