Support multiple extensions on --file-ext #1026
Conversation
|
Addresses issues: #896 feature request: allow multiple file-extensions in CLI |
cli.js
Outdated
| processDirectory(inputFile, outputFile, fileExt); | ||
| } | ||
| else if (!fileExt || path.extname(file) === '.' + fileExt) { | ||
| else if (!fileExt || fileExt.includes(path.extname(file).substring(1))) { |
There was a problem hiding this comment.
Please use ~fileExt.indexOf(path.extname(file).slice(1)) instead.
There was a problem hiding this comment.
Thanks. I wasn't aware Arrays.includes is an ES7 feature. :) Updated the pull request with an amend and a force push.
|
@kangax very sorry to bother you again, but looks like Travis can't build PR branches from forked repositories 😅 |
|
@kangax so I think given all the recent hassle, it's best if we:
... since it's better to have some progress than none at all. |
|
@kangax any luck? |
|
@alexlamsl sorry, been travelling. Wish I could just give you access to travis. I'll try to get to it today/tomorrow. |
|
@kangax @alexlamsl Any update? |
|
Took this to update HTML Minifier Next (compatible and maintained fork of HTML Minifier)—PR j9t/html-minifier-next#45, available with version 1.3.2. |
4 participants
This pull request adds support for multiple extensions on
--file-ext.For example:
This can filter out all supported extensions
html,htm,json,xml,yml,yamlin one go.