You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CLI: leave the npm packages out of the takumi-cli crate - #2671
The release after #2653 published to npm, then stopped at takumi-cli@0.2.0 on crates.io. Packing the npm packages leaves pkg.tgz files under takumi-cli/npm/, and cargo publish refused the crate because those files were uncommitted inside it. The publish job ended there, so the crate and the GitHub releases were never made.
What
takumi-cli/Cargo.toml excludes npm/, which the crate never needed: it shipped 13 npm files before.
takumi-cli/npm/.gitignore ignores *.tgz.
With pkg.tgz files in place, cargo publish --dry-run --locked -p takumi-cli now packages 38 files and passes the dirty check. The next publish run on master should publish takumi-cli@0.2.0 and the releases.
Summary by CodeRabbit
Chores
CLI package releases now exclude the npm directory, keeping that content out of published packages.
Generated .tgz archives are now excluded from version control, reducing the chance that local package archives are included in repository changes.
kane50613/takumi#2650: Adds npm packaging for takumi-cli, which is connected to the npm/ directory excluded by this change.
Merge Risk: Minimal · up to 69f51
The change keeps generated npm tarballs out of the takumi-cli crate package, so the next release run on master should be able to publish the crate. The release tooling skips npm versions that are already published, so the earlier partial release should not block the retry. No actionable merge risk remains.
Pre-merge checks: 7
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "CLI: leave the npm packages out of the takumi-cli crate" matches the main change. The Cargo.toml change excludes the npm/ directory from the takumi-cli crate package, and the .gitignore cha…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Chromium Parity
The check passes when the PR does not change rendered or measured output. The PR changes only two files: takumi-cli/Cargo.toml adds exclude = ["npm/"] to the crate packaging metadata, and `takumi-…
Golden Fixture
The check passes when the PR does not change rendered or serialized output. The PR changes only two files: takumi-cli/Cargo.toml adds exclude = ["npm/"] to the crate packaging metadata, and `takum…
Refactor Stays Separate
The check applies to commits described as a refactor, rename, or move, or that restructure code while changing output. This PR is a single commit titled "CLI: leave the npm packages out of the takumi-…
Full details: Title check
Explanation
The title "CLI: leave the npm packages out of the takumi-cli crate" matches the main change. The Cargo.toml change excludes the npm/ directory from the takumi-cli crate package, and the .gitignore change keeps packed *.tgz artifacts out of the repository. The objectives say the goal is to stop packed npm artifacts from blocking cargo publish of takumi-cli. The title is specific and concise, and it names the crate and the npm packages.
Full details: Chromium Parity
Explanation
The check passes when the PR does not change rendered or measured output. The PR changes only two files: takumi-cli/Cargo.toml adds exclude = ["npm/"] to the crate packaging metadata, and takumi-cli/npm/.gitignore adds *.tgz. Neither file touches rendering, layout, text measurement, or any Rust source. The change therefore does not alter rendered or measured output, so the Blink or spec-reference alternative does not need to be met.
Full details: Golden Fixture
Explanation
The check passes when the PR does not change rendered or serialized output. The PR changes only two files: takumi-cli/Cargo.toml adds exclude = ["npm/"] to the crate packaging metadata, and takumi-cli/npm/.gitignore adds *.tgz. Neither file affects rendered or serialized output. The diff contains no changes to takumi, takumi-pdf, or takumi-cli source, and no golden fixture is needed. The check therefore passes without a golden file under the named fixtures-generated directories.
Full details: Refactor Stays Separate
Explanation
The check applies to commits described as a refactor, rename, or move, or that restructure code while changing output. This PR is a single commit titled "CLI: leave the npm packages out of the takumi-cli crate". It is a fix, not a refactor, rename, or move. The diff touches two files, each with one added line: - takumi-cli/Cargo.toml adds exclude = ["npm/"]. - takumi-cli/npm/.gitignore adds *.tgz. No code is restructured, renamed, or moved. The packaged file set changes, but that is a configuration change, not a code restructure. The check does not apply, so it passes. No golden-file evidence is needed for this verdict.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 247dfb7 and 69f51e7.
Files selected for processing: 2
takumi-cli/Cargo.toml
takumi-cli/npm/.gitignore
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release after #2653 published to npm, then stopped at
takumi-cli@0.2.0on crates.io. Packing the npm packages leavespkg.tgzfiles undertakumi-cli/npm/, andcargo publishrefused the crate because those files were uncommitted inside it. The publish job ended there, so the crate and the GitHub releases were never made.What
takumi-cli/Cargo.tomlexcludesnpm/, which the crate never needed: it shipped 13 npm files before.takumi-cli/npm/.gitignoreignores*.tgz.With
pkg.tgzfiles in place,cargo publish --dry-run --locked -p takumi-clinow packages 38 files and passes the dirty check. The next publish run on master should publishtakumi-cli@0.2.0and the releases.Summary by CodeRabbit
.tgzarchives are now excluded from version control, reducing the chance that local package archives are included in repository changes.