V13 preset-menu full refactor

[Kapuzenjoe]

Hello,
I have reconfigured the entire preset menu and upgraded it to AppV2. I also added additional customizable elements.

I also renamed the name field, which was used to name the preset, to label. This now also makes it possible to customize the token name with ATL. (For example, if you want to set the token name to unknown, you can do this with an active effect.) I have added a small upgrade script for this.

With the changes related to AppV2, ATL would only be possible with V13 or higher.

New select menu:

New preset menu:

Further along, I wanted to add additional editable elements. In particular, the detection mode is currently missing (it wasn't available in the old version either).

As well as optimize and clean up the code.

[Nocotov77]

Hi I use your fork with latest beta MidiQOL and DAE. And I can't use ATL.preset key.

[Kapuzenjoe]

Hello,
The problem here lies in the change from preset.name to preset.label for preset names (to keep the .name attribute free for use). In my PR, I'm also migrating the existing presets from .name to .label so there are no conflicts in the module itself.

However, the detection of possible ATE keys is hardcoded in DAE and not via ATE. There, DAE explicitly searches for preset.name and then lists it in the DAE browser.

I can see if I can manipulate the DAE query from ATE for the time being or remove the .label attribute again. It would be best if the detection for the DAE browser were done via this module, so there are fewer dependencies. Otherwise, DAE needs a code change.

Maybe @kaelad02 has a better suggestion.

[Kapuzenjoe]

@Nocotov77
I've removed the preset.label attribute and reverted to preset.name for naming presets. This should make DAE compatible again.

For changing the token name, I've introduced a different method for now.

[nesretep]

How do I install your version of ATL? The manifest.json file here points to a repo you forked.

[strongpauly]

@Kapuzenjoe a release with these changes would be greatly appreciated - it should just be a case of enabling github actions on your fork and creating a release.

Also, AppV2 was introduced in v12, so its possible any release including these changes could work there too.

[tposney]

Happy to make changes to DAE for the present.label rather than name - if the release gets published.
It is also possible for ATL to add in the keys it wants to dae, rather than dae hard coding them.

[Kapuzenjoe]

Good Morning,
@nesretep You can download the source code as a zip file and replace the files in an existing ATL installation (you'll need the src and template folders). An update via Foundry would overwrite them.

@strongpauly @kaelad02 is currently the repository maintainer. He will review and test the PR when he has the opportunity.

@tposney Thank you very much for the information. With my latest change, changing the label is no longer necessary, as I've found a workaround. I'm open to suggestions as to which approach is better. :)
The ATL keys for DAE directly in ATL might be better for future maintenance. You could consider this after this PR.

Generally speaking, this PR isn't 100% finished yet, as I still want to add the detection modes to the preset menu. I'll do that in the next few days when I get the chance.

[Fronix]

@Kapuzenjoe not sure if this is something that fits in this but seems like the ATL selector in general doesn't work anymore.

Tested both the current and your version

[tposney]

I tested this with a clone of about to be merged version and it seems to be working for me. I'm on latest foundry/dae. Is the weapon attuned and equipped?

I think the issue is that for enchantments, by default all changes are applied to the item being enchanted and not to the actor. So you'd need to create an additional effect, with the light changes (and make sure apply to actor is set). And then in the enchantment config add the light effect in the additional settings section

[Fronix]

I tested this with a clone of about to be merged version and it seems to be working for me. I'm on latest foundry/dae. Is the weapon attuned and equipped?

I think the issue is that for enchantments, by default all changes are applied to the item being enchanted and not to the actor. So you'd need to create an additional effect, with the light changes (and make sure apply to actor is set). And then in the enchantment config add the light effect in the additional settings section

You are correct, adding a passive effect with the light did the trick