Add gensym and clean or macro
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall looks good so far. I would probably leave the core.mal loading and "->" test in step8 to keep them with the macro step and then just drop the "and" tests. I had been thinking for a while to reduce the "and" tests. Slow implementations are especially slow with macros and the "and" macro is so similar to "or" macro that the tests for it are fairly redundant. If anything, one or two tests for "->>" in step8 would be more useful since that is a more complex macro. |
|
OK, sounds good, I'll restore core.mal back to step8 and replace |
1. `gensym` isn't yet available in step8 2. `and` tests are very slow in some implementations 3. ->> macro is more complex 4. moved core.mal to the end so it won't override the builtin `or` macro
* go * guile * js * mal * miniMAL * ocaml * ps * python * racket * ruby * tcl * vimscript
* bash * c * clojure * coffee * crystal * d * elixir * erlang * forth * lua * make * nim * perl
* awk * cpp * cs * es6 * factor * fsharp * groovy * haskell * java * julia * kotlin * matlab * php * r * rpython * rust * scala * swift * vb
|
As far as I can see all implementations pass the soft test at the end of test A which tests |
kanaka
added a commit
that referenced
this pull request
Jan 26, 2016
Add gensym and clean `or` macro
|
Nice work. |
Closed
micfan
pushed a commit
to micfan/make-a-lisp
that referenced
this pull request
Nov 8, 2018
Add gensym and clean `or` macro
luelista
pushed a commit
to luelista/mal
that referenced
this pull request
Mar 10, 2024
Add gensym and clean `or` macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Following discussion in #126)
This PR introduces
gensymin the optional stage of stepA, implemented in Mal itself (part of therepcalls at the beginning of the program), and a cleanormacro which doesn't shadow caller bindings.There are separate commits for changes in tests, process, guide, core.mal, and then one commit which modifies the actual stepA code of 12 implementations (all pass the new tests of stepA).
If this looks good, I'll continue implementing the change on the rest of the implementations.