Native swap! implementation for cpp #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some initial confusion about which env to pass to the eval builtin, I'd been needlessly passing an env to apply all along. No need.
kanaka
added a commit
that referenced
this pull request
Dec 18, 2015
Native swap! implementation for cpp
|
Thanks! |
micfan
pushed a commit
to micfan/make-a-lisp
that referenced
this pull request
Nov 8, 2018
Native swap! implementation for cpp
luelista
pushed a commit
to luelista/mal
that referenced
this pull request
Mar 10, 2024
Native swap! implementation for cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the native swap! implementation, along with a minor env-passing cleanup.
The extra args are passed directly, there's no varargs handling like apply does. I can add that if necessary.
See #130