fix: grammar typo Priviliges -> Privileges in PostgreSQL #8016
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
A. Is it good to PR contributing.md for it?
B. Is it good to PR an addition of nix-shell?
A. Is it good to PR contributing.md for it?
2. npm run dev 'issue'
(side note: this 10407ms went to 224ms after some runs)
I got a little confused, I used a nix-shell with nodejs_23:
The README.md says I need to 'npm i' and 'npm run dev', so I'm curious as to the:
In my noob glance, if the only command I run is npm stuff, PHP shouldn't be involved. Would be glad if someone could help me understand why. Also, I can submit a PR adding the need of PHP to the contributing.md if that is a necessity, or some other content to it, to help other noobs if they see this message in the wild whilst contributing here/there.
What I tried
I used this nix-shell, and PHP is installed:
nix-shell:~/xaviduds/developer-roadmap]$ php --version PHP 8.3.15 (cli) (built: Dec 17 2024 18:18:02) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.15, Copyright (c) Zend Technologies with Zend OPcache v8.3.15, Copyright (c), by Zend Technologies
My question here is, do you believe this is a problem with my nix-shell, or is this warnings are nix-shell agnostic? If it's not a nix-shell problem I would like to add a default.nix (nix-shell) to the developer-roadmap repo in a PR. I write this to see the will of the project about it. This would facilitate getting up and running with a way of installing ephemerally the necessary packages, isolated from the system, version controlled, in any system that has Nix installed.
3. Rendering Permission
Just out of curiosity, on the postgresql-dba page, after some loading, the roadmap cards didn't render, as shown below:I believe this is on purpose and since I don't have access to the generate-renderer the 'npm run generate-renderer' didn't work.
Result
But, I opened the page in localhost to see if my changes where correct, for contributing dev's this might be usefull, to be able to use I think, just a suggestion. I can also add to the contributing.md the heads up, that in localhost devs without this wont be able to check rendered roadmaps.