Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grammar typo Priviliges -> Privileges in PostgreSQL #8016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaviduds
Copy link
Contributor

TL;DR:

  1. PR with grammar fix
  2. Warnings when running 'npm run dev'.
    A. Is it good to PR contributing.md for it?
    B. Is it good to PR an addition of nix-shell?
  3. Rendering Permission
    A. Is it good to PR contributing.md for it?

  1. There where two cards with this grammar typo, I fixed the name of the file and the label.

2. npm run dev 'issue'

(side note: this 10407ms went to 224ms after some runs)

1:31:34 [200] / 10407ms
[Shiki] The language "PHP" doesn't exist, falling back to "plaintext".
11:32:05 [200] /postgresql-dba 83ms
11:32:18 [WARN] [router] A `getStaticPaths()` route pattern was matched, but no matching static path was found for requested path `/undefined/v1-get-sponsor`.

Possible dynamic routes being matched: src/pages/[roadmapId]/[...topicId].astro.
11:32:19 [200] /postgresql-dba.json 1ms
11:32:19 [WARN] [router] A `getStaticPaths()` route pattern was matched, but no matching static path was found for requested path `/undefined/v1-list-roadmap-paid-resources/postgresql-dba`.

Possible dynamic routes being matched: src/pages/[roadmapId]/[...topicId].astro.
11:32:19 [200] /pages.json 18ms
11:32:19 [404] /undefined/v1-get-sponsor 180ms
11:32:19 [404] /undefined/v1-list-roadmap-paid-resources/postgresql-dba 180ms

I got a little confused, I used a nix-shell with nodejs_23:

 node --version
v23.2.0

The README.md says I need to 'npm i' and 'npm run dev', so I'm curious as to the:

[Shiki] The language "PHP" doesn't exist, falling back to "plaintext".

In my noob glance, if the only command I run is npm stuff, PHP shouldn't be involved. Would be glad if someone could help me understand why. Also, I can submit a PR adding the need of PHP to the contributing.md if that is a necessity, or some other content to it, to help other noobs if they see this message in the wild whilst contributing here/there.

What I tried
{
  pkgs ? import <nixpkgs> { },
}:
pkgs.mkShell {
  buildInputs = with pkgs; [
    nodejs_23
    pnpm
    php
  ];
  shellHook = ''
    cd ${toString ./.}
    npm run dev
  '';
}

I used this nix-shell, and PHP is installed:

nix-shell:~/xaviduds/developer-roadmap]$ php --version
PHP 8.3.15 (cli) (built: Dec 17 2024 18:18:02) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.15, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.15, Copyright (c), by Zend Technologies

My question here is, do you believe this is a problem with my nix-shell, or is this warnings are nix-shell agnostic? If it's not a nix-shell problem I would like to add a default.nix (nix-shell) to the developer-roadmap repo in a PR. I write this to see the will of the project about it. This would facilitate getting up and running with a way of installing ephemerally the necessary packages, isolated from the system, version controlled, in any system that has Nix installed.


3. Rendering Permission Just out of curiosity, on the postgresql-dba page, after some loading, the roadmap cards didn't render, as shown below:

screenshot

I believe this is on purpose and since I don't have access to the generate-renderer the 'npm run generate-renderer' didn't work.

Result
 [email protected] generate-renderer
> sh scripts/generate-renderer.sh

Cloning into '.temp/web-draw'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

But, I opened the page in localhost to see if my changes where correct, for contributing dev's this might be usefull, to be able to use I think, just a suggestion. I can also add to the contributing.md the heads up, that in localhost devs without this wont be able to check rendered roadmaps.

Commits done in PostgreSQL Roadmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant