Warn on finished span in runWithSpan #936
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimunKaracic
force-pushed
the
warn-when-running-finished-span
branch
2 times, most recently
from
367d3bb to
b7cec7e
Compare
|
Given that this issue is related to the comments on #913, I wouldn't limit the warnings to And this opens two questions:
|
When enabled, will warn when trying to change closed spans
SimunKaracic
force-pushed
the
warn-when-running-finished-span
branch
from
b7cec7e to
7c5d817
Compare
|
Added flag, and a bunch of log messages everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.