expose text Content-Type in embedded http server #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantopo
reviewed
Apr 9, 2025
| import java.net.URL | ||
| import java.net.{URL, URLConnection} | ||
| import java.util.zip.GZIPInputStream | ||
| import scala.jdk.CollectionConverters._ |
There was a problem hiding this comment.
This import does not work with earlier Scala versions, but I'm about to merge removing support for Scala 2.11 and 2.12. Probably there is no need to change this but just wait until #1387 gets merged
|
We encountered the same issue with Prometheus 3, would be great to change that content type. |
|
Hi! Just wanted to follow up on this PR. |
xela85
force-pushed
the
set-proper-content-type-embedded-server
branch
from
140c3b5 to
88e9897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, the Kamon embedded server does not set the
Content-Typein its response headers.This breaks Prometheus 3.0 which requires this header to be properly set :
https://prometheus.io/docs/prometheus/3.0/migration/#scrape-protocols
To fix this issue, I have modified
SunHttpServerSpecSuite