make kamon-pekko tolerant of null dispatcherPrerequisites #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been spending some time today trying to figure out what's causing this (cf #1362) and honestly I'm not sure, but it seems like various pieces of instrumentation aren't working... Especially in scala 2.13. Scala 3 doesn't seem to have any issues.. so that's odd. Would rather the instrumentation tests passed for pekko 1.1, because otherwise we're probably hiding errors... |
|
@hughsimpson feel free to do a new PR that sorts out the instrumentation issue. This PR is useful as far as I am concerned because it stops Kamon from crashing the JVM. To repeat what I said in the PR description: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1352
unit tests pass and tested with https://github.com/pjfanning/kamon-pekko-http-test
The NPE may pop up in other use cases but this sorts the one seen in #1352
I know a fuller fix is needed - one that ensures the dispatcherPrerequisites are found but that can be done independently.