feat: make the brotli-size dependency optional
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbailey4
force-pushed
the
feature/optional-brotli
branch
from
b3e0082 to
02320a7
Compare
simonihmig
requested changes
May 13, 2019
lib/helpers/compressed-size.js
Outdated
| brotli = require('brotli-size'); | ||
| console.log(brotli); | ||
| } catch (error) { | ||
| console.log(error); |
There was a problem hiding this comment.
Please remove all console.log output.
lib/helpers/compressed-size.js
Outdated
| console.log(brotli); | ||
| } catch (error) { | ||
| console.log(error); | ||
| throw new Error( |
There was a problem hiding this comment.
Please add this pkg to dependencies and throw a SilentError instead, which will have some better UX (no stack trace): https://github.com/ember-cli/silent-error
README.md
Outdated
| @@ -15,6 +15,13 @@ ember install ember-cli-bundlesize | |||
|
|
|||
| Make sure to `git add` the added `config/bundlesize.js` file! | |||
|
|
|||
| #### Optional dependency | |||
|
|
|||
| If you're app uses brotli compression and the `brotli` option is set in your configuration (i.e `compression: 'brotli'`), you must install the optional dependency: `brotli-size`. | |||
There was a problem hiding this comment.
Suggested change
| If you're app uses brotli compression and the `brotli` option is set in your configuration (i.e `compression: 'brotli'`), you must install the optional dependency: `brotli-size`. | |
| If your app uses Brotli compression and the `brotli` option is set in your configuration (i.e `compression: 'brotli'`), you must install the optional dependency: `brotli-size`. |
jbailey4
force-pushed
the
feature/optional-brotli
branch
2 times, most recently
from
727c749 to
d0872f8
Compare
jbailey4
force-pushed
the
feature/optional-brotli
branch
from
d0872f8 to
d24d80c
Compare
|
@simonihmig Addressed the feedback and build is now passing. Ready for another review! |
|
Published as 0.2.0! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8