-
Notifications
You must be signed in to change notification settings - Fork 14
Apply lints #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EdJoPaTo
wants to merge
23
commits into
kaitai-io:master
Choose a base branch
from
EdJoPaTo:improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Apply lints #7
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
58219f7
build: rust-version >= 1.63, edition 2021 and lock file
EdJoPaTo d896728
style: cargo fmt
EdJoPaTo f533894
refactor: fix lints
EdJoPaTo d1c367f
refactor(lint): unused_qualifications
EdJoPaTo 07f8724
refactor: slice[..] is a noop
EdJoPaTo e84a100
refactor(lint): clippy::min_ident_chars
EdJoPaTo b5c6f47
refactor(lint): redundant_imports
EdJoPaTo deded59
refactor(lint): trivial_casts
EdJoPaTo 686719e
refactor(lint): clippy::unreadable_literal
EdJoPaTo 11437d3
refactor(lint): clippy::semicolon_if_nothing_returned
EdJoPaTo 97d8015
refactor(lint): clippy::bool_to_int_with_if
EdJoPaTo 6647c02
refactor(lint): clippy::needless_pass_by_value
EdJoPaTo 984164c
refactor(lint): clippy::manual_assert
EdJoPaTo 3fe7773
refactor(lint): clippy::single_match_else
EdJoPaTo ff5283b
refactor(lint): clippy::inline_always
EdJoPaTo dae8375
refactor(lint): clippy::cast…
EdJoPaTo 5f59f09
build(lint): enable all clippy::pedantic lints
EdJoPaTo 5bdcb30
refactor(lint): clippy::use_self
EdJoPaTo 6a169a3
refactor(lint): clippy::precedence_bits
EdJoPaTo be60e33
refactor(lint): clippy::derive_partial_eq_without_eq
EdJoPaTo ec6ed9f
refactor(lint): clippy::str_to_string
EdJoPaTo 9b9df77
refactor(lint): prepare breaking changes
EdJoPaTo afb42f1
perf: move downcast out of trait
EdJoPaTo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,3 @@ | |
| .vscode/ | ||
| /target | ||
| **/*.rs.bk | ||
| Cargo.lock | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,13 +2,36 @@ | |
| name = "kaitai" | ||
| version = "0.2.0" | ||
| authors = ["Bradlee Speice <[email protected]>", "Aon"] | ||
| edition = "2018" | ||
| edition = "2021" | ||
| rust-version = "1.63" | ||
|
|
||
| [features] | ||
| type_name_of_val = [] | ||
|
|
||
| [lints.rust] | ||
| redundant_imports = "warn" | ||
| trivial_casts = "warn" | ||
| unsafe_code = "forbid" | ||
| unused_qualifications = "warn" | ||
| [lints.clippy] | ||
| pedantic = { level = "warn", priority = -1 } | ||
| str_to_string = "warn" | ||
| min_ident_chars = "warn" | ||
| precedence_bits = "warn" | ||
|
|
||
| derive_partial_eq_without_eq = "warn" | ||
| use_self = "warn" | ||
|
|
||
| missing_errors_doc = "allow" | ||
| missing_panics_doc = "allow" | ||
| must_use_candidate = "allow" | ||
| used_underscore_binding = "allow" # _io and so on are the same as on other reader implementations | ||
|
|
||
| [dependencies] | ||
| encoding-next = "0.3" | ||
| cp437 = "*" | ||
| unicode-segmentation = "1.9.0" | ||
| flate2 = "1.0" | ||
| cp437 = "0.1" | ||
| unicode-segmentation = "1" | ||
| flate2 = "1" | ||
|
|
||
| [dev-dependencies] | ||
| tempfile = "3.4.0" | ||
| tempfile = "3" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| avoid-breaking-exported-api = true # TODO: change (and keep) to false on breaking change release |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.63 was the oldest version I managed to build. This is partially the case as a
Cargo.lockwas missing before. I added the lock file to simplify these checks against the oldest supported version in the future.As 1.63 already supports edition 2021, I updated the edition too.