Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
58219f7
build: rust-version >= 1.63, edition 2021 and lock file
EdJoPaTo Sep 8, 2025
d896728
style: cargo fmt
EdJoPaTo Sep 8, 2025
f533894
refactor: fix lints
EdJoPaTo Sep 8, 2025
d1c367f
refactor(lint): unused_qualifications
EdJoPaTo Sep 8, 2025
07f8724
refactor: slice[..] is a noop
EdJoPaTo Sep 8, 2025
e84a100
refactor(lint): clippy::min_ident_chars
EdJoPaTo Sep 8, 2025
b5c6f47
refactor(lint): redundant_imports
EdJoPaTo Sep 8, 2025
deded59
refactor(lint): trivial_casts
EdJoPaTo Sep 8, 2025
686719e
refactor(lint): clippy::unreadable_literal
EdJoPaTo Sep 8, 2025
11437d3
refactor(lint): clippy::semicolon_if_nothing_returned
EdJoPaTo Sep 8, 2025
97d8015
refactor(lint): clippy::bool_to_int_with_if
EdJoPaTo Sep 8, 2025
6647c02
refactor(lint): clippy::needless_pass_by_value
EdJoPaTo Sep 8, 2025
984164c
refactor(lint): clippy::manual_assert
EdJoPaTo Sep 8, 2025
3fe7773
refactor(lint): clippy::single_match_else
EdJoPaTo Sep 8, 2025
ff5283b
refactor(lint): clippy::inline_always
EdJoPaTo Sep 8, 2025
dae8375
refactor(lint): clippy::cast…
EdJoPaTo Sep 8, 2025
5f59f09
build(lint): enable all clippy::pedantic lints
EdJoPaTo Sep 8, 2025
5bdcb30
refactor(lint): clippy::use_self
EdJoPaTo Sep 8, 2025
6a169a3
refactor(lint): clippy::precedence_bits
EdJoPaTo Sep 8, 2025
be60e33
refactor(lint): clippy::derive_partial_eq_without_eq
EdJoPaTo Sep 8, 2025
ec6ed9f
refactor(lint): clippy::str_to_string
EdJoPaTo Sep 8, 2025
9b9df77
refactor(lint): prepare breaking changes
EdJoPaTo Sep 8, 2025
afb42f1
perf: move downcast out of trait
EdJoPaTo Sep 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
.vscode/
/target
**/*.rs.bk
Cargo.lock
295 changes: 295 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 28 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,36 @@
name = "kaitai"
version = "0.2.0"
authors = ["Bradlee Speice <[email protected]>", "Aon"]
edition = "2018"
edition = "2021"
rust-version = "1.63"
Comment on lines +5 to +6
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.63 was the oldest version I managed to build. This is partially the case as a Cargo.lock was missing before. I added the lock file to simplify these checks against the oldest supported version in the future.

As 1.63 already supports edition 2021, I updated the edition too.


[features]
type_name_of_val = []

[lints.rust]
redundant_imports = "warn"
trivial_casts = "warn"
unsafe_code = "forbid"
unused_qualifications = "warn"
[lints.clippy]
pedantic = { level = "warn", priority = -1 }
str_to_string = "warn"
min_ident_chars = "warn"
precedence_bits = "warn"

derive_partial_eq_without_eq = "warn"
use_self = "warn"

missing_errors_doc = "allow"
missing_panics_doc = "allow"
must_use_candidate = "allow"
used_underscore_binding = "allow" # _io and so on are the same as on other reader implementations

[dependencies]
encoding-next = "0.3"
cp437 = "*"
unicode-segmentation = "1.9.0"
flate2 = "1.0"
cp437 = "0.1"
unicode-segmentation = "1"
flate2 = "1"

[dev-dependencies]
tempfile = "3.4.0"
tempfile = "3"
1 change: 1 addition & 0 deletions clippy.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
avoid-breaking-exported-api = true # TODO: change (and keep) to false on breaking change release
Loading