-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kaiax/gasless: Implement worker for tx bundle #272
Merged
Mdaiki0730
merged 39 commits into
kaiachain:feat/gasless
from
Mdaiki0730:feat/impl-worker-bundling
Mar 10, 2025
Merged
kaiax/gasless: Implement worker for tx bundle #272
Mdaiki0730
merged 39 commits into
kaiachain:feat/gasless
from
Mdaiki0730:feat/impl-worker-bundling
Mar 10, 2025
+900
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d36021
to
2185890
Compare
ian0371
reviewed
Mar 7, 2025
ulbqb
reviewed
Mar 7, 2025
Co-authored-by: Chihyun Song <[email protected]>
ian0371
approved these changes
Mar 7, 2025
In terms of timeout test, temporarily setting timeout to 150us depends on PC spec, so timeout can occur (1) before executing any txs, (2) during tx execution, (3) after all tx execution. In case of (1), the test can fail. In case of (3), the test will be successful but timeout wouldn't have occurred. Later let's improve accuracy of timeout test so timeout almost always occurs at (2).
|
hyeonLewis
reviewed
Mar 7, 2025
ulbqb
reviewed
Mar 7, 2025
… in txGen Co-authored-by: Lewis <[email protected]>
ian0371
reviewed
Mar 7, 2025
ian0371
reviewed
Mar 7, 2025
Co-authored-by: Chihyun Song <[email protected]>
hyeonLewis
reviewed
Mar 8, 2025
hyeonLewis
reviewed
Mar 9, 2025
ian0371
reviewed
Mar 10, 2025
ulbqb
approved these changes
Mar 10, 2025
hyeonLewis
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merging this PR will enable worker bundling in kip-245.
New features about kip-245
Also, some changes were made to implement above.
RegisterTxBundlingModule
, a node can use it to register theTxBundlingModule
.About Pop and Shift
We create a dependency graph during pop for the following reasons.
Shift just advances to the next tx, while pop deletes all tx that have the same sender as the failed tx.
This deletion may affect other bundles in the following cases:
Create TestScenario
Create a mock TxBundlingModule and create a bundle for each two tx.
At that point, tx4 fails with nonceTooHigh and tx3 is reverted.
There were also some test util changes.
TxBundlingModules
andBuilderModules
toMineABlock
.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...