Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kaiax/builder: Add module skeleton #261

Merged
merged 25 commits into from
Mar 4, 2025
Merged

kaiax/builder: Add module skeleton #261

merged 25 commits into from
Mar 4, 2025

Conversation

ian0371
Copy link
Collaborator

@ian0371 ian0371 commented Feb 20, 2025 •
edited
Loading

Proposed changes

Implement skeleton of KIP-245.
Because the result can contain TxGenerator, the return type of IncorporateBundleTx is []interface{}.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@ian0371 ian0371 self-assigned this Feb 20, 2025
@ian0371 ian0371 marked this pull request as ready for review February 25, 2025 09:00
blukat29
blukat29 reviewed Feb 25, 2025
View reviewed changes
@Mdaiki0730
Copy link
Contributor

Would you like to change the copyright year in the new file from 2024 to 2025?

Mdaiki0730
Mdaiki0730 reviewed Feb 27, 2025
View reviewed changes
ulbqb
ulbqb reviewed Mar 4, 2025
View reviewed changes
@ian0371 ian0371 merged commit cf0ebf0 into kaiachain:feat/gasless Mar 4, 2025
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@ulbqb ulbqb ulbqb approved these changes

@Mdaiki0730 Mdaiki0730 Mdaiki0730 approved these changes

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@yoomee1313 yoomee1313 Awaiting requested review from yoomee1313 yoomee1313 is a code owner

@shiki-tak shiki-tak Awaiting requested review from shiki-tak

Assignees

@ian0371 ian0371

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ian0371 @Mdaiki0730 @blukat29 @shiki-tak @ulbqb @hyeonLewis