Skip to content

fix(helm): use fullname in selector labels to prevent mismatch on upgrade #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EItanya merged 2 commits into from
Mar 5, 2026
+5 −5
Merged

fix(helm): use fullname in selector labels to prevent mismatch on upgrade #47

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7751a89
fix(helm): use fullname in selector labels to prevent mismatch on upg…
jsonmp-k8 Mar 5, 2026
609d94c
fix(e2e): update label selectors to match fullname-based selector labels
EItanya Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/kagent-tools/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
Selector labels
*/}}
{{- define "kagent.selectorLabels" -}}
app.kubernetes.io/name: {{ include "kagent.name" . }}
app.kubernetes.io/name: {{ include "kagent.fullname" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}

Expand Down
2 changes: 1 addition & 1 deletion helm/kagent-tools/tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,5 +171,5 @@ tests:
- equal:
path: spec.template.spec.topologySpreadConstraints[0].labelSelector.matchLabels
value:
app.kubernetes.io/name: kagent-tools
app.kubernetes.io/name: RELEASE-NAME
app.kubernetes.io/instance: RELEASE-NAME
Loading