feat: add token support for kubectl commands#37
Merged
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
sam-heilbron
approved these changes
Dec 30, 2025
dimetron
approved these changes
Jan 5, 2026
Collaborator
|
@EItanya I have only concern if this will be consistent across all other tools |
Contributor
Author
I think that's fair, the issue is that not all CLIs allow for passing tokens in this way |
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
iplay88keys
force-pushed
the
eitanya/kubectl-token-support
branch
from
January 28, 2026 21:02
6f0cb36 to
fbc804d
Compare
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
mesutoezdil
pushed a commit
to mesutoezdil/tools
that referenced
this pull request
Jun 14, 2026
* feat: add token support for kubectl commands Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * use pre-v4 helm version Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * Add configuration to disable service token automount Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> * Remove automountServiceAccountToken config Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> * helm config for using default service account Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> * Add tools.k8s.tokenPassthrough for requiring token from auth header Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> * Fix helm version Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> * Remove automountServiceAccountToken from helm test Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> * Redact tokens Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io> Co-authored-by: Jeremy Alvis <jeremy.alvis@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users of the kagent tool server want to be able to use client authentication for
k8stools. In order to enable this, the k8s tools will now attempt to pass Bearer tokens from the request into thekubectlcommands.Introduces helm values for configuring this:
Testing
Defaults (matches current approach)
Output:
Token passthrough + disable service account
With token:
Without token, the client receives:
Bearer token required when TOKEN_PASSTHROUGH is true