Skip to content

fix(helm): omit empty repository segment in bundled image path #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EItanya merged 4 commits into from
Jul 2, 2026
+22 −1
Merged

fix(helm): omit empty repository segment in bundled image path #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb7add8
fix(helm): omit empty repository segment in bundled image path
michaelspinks Jun 30, 2026
baae3f7
Merge branch 'kagent-dev:main' into fix/image-empty-repository-double…
michaelspinks Jun 30, 2026
511220e
Merge branch 'main' into fix/image-empty-repository-double-slash
michaelspinks Jul 1, 2026
e214f4f
Merge branch 'main' into fix/image-empty-repository-double-slash
EItanya Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion helm/kagent/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,8 @@ Bundled PostgreSQL image - constructs the full image reference from registry/rep
*/}}
{{- define "kagent.postgresql.image" -}}
{{- $pg := .Values.database.postgres.bundled -}}
{{- printf "%s/%s/%s:%s" $pg.image.registry $pg.image.repository $pg.image.name $pg.image.tag -}}
{{- $parts := compact (list $pg.image.registry $pg.image.repository $pg.image.name) -}}
{{- printf "%s:%s" (join "/" $parts) $pg.image.tag -}}
Comment thread
michaelspinks marked this conversation as resolved.
{{- end -}}

{{/*
Expand Down
20 changes: 20 additions & 0 deletions helm/kagent/tests/postgresql_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,26 @@ tests:
path: spec.template.spec.containers[0].image
value: my-registry.example.com/myorg/postgres:15

- it: should omit empty repository segment in image
template: postgresql.yaml
documentIndex: 2
set:
database:
postgres:
bundled:
image:
registry: docker.io
repository: ""
name: postgres
tag: "18.3-alpine"
asserts:
- equal:
path: spec.template.spec.containers[0].image
value: docker.io/postgres:18.3-alpine
- notMatchRegex:
path: spec.template.spec.containers[0].image
pattern: "//"

- it: should read POSTGRES_PASSWORD from chart-managed secret
template: postgresql.yaml
documentIndex: 2
Expand Down
Loading