Skip to content

Trigger CI workflows on all release/** branches#2117

Merged
EItanya merged 1 commit into
mainfrom
iplay88keys/ci-run-on-release-branches
Jun 30, 2026
Merged

Trigger CI workflows on all release/** branches#2117
EItanya merged 1 commit into
mainfrom
iplay88keys/ci-run-on-release-branches

Conversation

@iplay88keys

Copy link
Copy Markdown
Contributor

Description

Switch the workflow branch filters from hardcoded release branch names to a release/** glob, so CI runs on every release branch instead of only the one that happened to be current when the filter was last edited.

Why

The filters hardcoded release/v0.7.x (or were main-only). release/v0.7.x is long superseded, so PRs targeting current release branches — e.g. release/v0.9.x — triggered no CI (only branch-agnostic checks like DCO/labelers/snyk ran). A release/** glob matches every current and future release branch, so this won't go stale on the next release cut.

Changes

branches filters updated to [main, "release/**"]:

  • ci.yaml — push + pull_request (was [main, release/v0.7.x])
  • ui-chromatic.yaml — push + pull_request (was [main, release/v0.7.x])
  • migration-immutability.yaml — pull_request (was [main])
  • sqlc-generate-check.yaml — pull_request (was [main])

No job logic changed — only the trigger branch filters. The glob still matches release/v0.7.x, so nothing that ran before stops running. migration-immutability and sqlc-generate-check were main-only and now also run on release-branch PRs (those checks are relevant to release branches too).

Notes

  • For pull_request, GitHub evaluates the trigger from the PR head's workflow file, so this takes effect for PRs cut from main once merged, and for future release branches cut from main.
  • Existing release branches carry their own stale copies of these filters and won't inherit this change — it must be backported to each active release branch (e.g. release/v0.9.x) for their PRs to get CI.

Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Copilot AI review requested due to automatic review settings June 30, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflow triggers so CI and related checks run for pull requests and pushes targeting any current/future release/** branches, avoiding stale hardcoded release branch filters.

Changes:

  • Updated ci.yaml to trigger on main and release/** for both push and pull_request.
  • Updated ui-chromatic.yaml to trigger on main and release/** for both push and pull_request.
  • Expanded migration-immutability.yaml and sqlc-generate-check.yaml pull_request branch filters to include release/**.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yaml Broadens CI triggers to include all release/** branches for pushes and PRs.
.github/workflows/ui-chromatic.yaml Broadens UI Storybook/Chromatic triggers to include all release/** branches for pushes and PRs.
.github/workflows/migration-immutability.yaml Runs migration immutability checks on PRs targeting release branches as well as main.
.github/workflows/sqlc-generate-check.yaml Runs sqlc generation checks on PRs targeting release branches as well as main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iplay88keys iplay88keys enabled auto-merge (squash) June 30, 2026 20:53
@iplay88keys iplay88keys disabled auto-merge June 30, 2026 20:53
@iplay88keys iplay88keys enabled auto-merge (squash) June 30, 2026 20:54
@EItanya EItanya disabled auto-merge June 30, 2026 20:56
@EItanya EItanya merged commit 83c8ae9 into main Jun 30, 2026
28 checks passed
@EItanya EItanya deleted the iplay88keys/ci-run-on-release-branches branch June 30, 2026 20:56
iplay88keys added a commit that referenced this pull request Jun 30, 2026
## Summary

Backport of #2117 to `release/v0.9.x`: switch the workflow branch
filters from hardcoded release names to a `release/**` glob so CI
actually runs on PRs targeting this release branch.

Cherry-pick of `83c8ae96` (`-x` provenance recorded).

## Why this is needed on the release branch

Workflow `branches` filters are per-branch. `release/v0.9.x`'s copies
still read `[main, release/v0.7.x]` (or `[main]`), so PRs targeting
`release/v0.9.x` trigger no CI — only branch-agnostic checks
(DCO/labelers/snyk) run. The `main` fix in #2117 does not affect this
branch on its own; existing release branches carry their own filters and
must have the change backported.

## Changes

`branches` filters updated to `[main, "release/**"]`:

- `ci.yaml` — push + pull_request
- `ui-chromatic.yaml` — push + pull_request
- `migration-immutability.yaml` — pull_request
- `sqlc-generate-check.yaml` — pull_request

Trigger filters only; no job logic changed. The glob still matches
`release/v0.7.x`, so nothing that ran before stops.

Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants