fix the issue where sandbox agents couldn't be added as tools

[peterj]

Fixes an issue where we always assumed agents where of Agent kind. The agent in the tool dialog shows the correct type now too. (a lot of changes in the tsx file, but it's mostly formatting)

[chromatic-com]

Warning

Testing paused

Monthly snapshot limit reached. Update your plan for additional snapshots and to resume testing.

[Copilot]

Pull request overview

This PR fixes adding sandbox-backed agents as tools by making agent tool references kind-aware end-to-end (UI → tool reference payload → translator resolution), and updates the tool selection UI to display the correct agent kind.

Changes:

• UI: include agent kind when creating an Agent tool reference and display the kind in the tools dialog.
• Translator: resolve Agent tools by TypedReference.Kind (defaulting to Agent) and generate the correct A2A URL for sandbox agents via the controller proxy.
• Tests: add coverage ensuring kind-based resolution, default-kind behavior, self-reference prevention, and sandbox URL routing.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
ui/src/components/create/SelectToolsDialog.tsx	Updates agent tool selection/representation in the dialog, including kind display and tool payload kind.
go/core/internal/controller/translator/agent/compiler.go	Implements kind-aware agent-tool resolution, kind-qualified cycle/self-reference checks, and sandbox proxy URL generation.
go/core/internal/controller/translator/agent/sandbox_agent_tool_test.go	Adds unit tests validating kind-aware agent tool resolution and sandbox routing behavior.

Comments suppressed due to low confidence (3)

ui/src/components/create/SelectToolsDialog.tsx:263

• Selection logic for agent items matches only by name/namespace, so selecting a SandboxAgent will also mark an Agent with the same namespace/name as selected (and vice-versa). Compare the tool reference kind as well so Agent vs SandboxAgent remain distinct.

  const isItemSelected = (item: ToolsResponse | AgentResponse): boolean => {
    if (isAgentResponse(item)) {
      const agentResp = item as AgentResponse;

      // "item" is an agent but called item to here so as not to confuse

ui/src/components/create/SelectToolsDialog.tsx:897

• When rendering selected agent tools, the lookup of matchedAgent ignores the tool reference kind. If an Agent and SandboxAgent share the same namespace/name, the UI can show the wrong description/type in the selected list. Match on kind as well (defaulting missing kinds to "Agent").

                      const matchedAgent = isAgentTool(tool)
                        ? availableAgents.find((a) => {
                            const agentName = tool.agent?.name;
                            const agentNamespace = tool.agent?.namespace;

                            // Match by name and namespace (if namespace is specified)
                            if (agentNamespace) {
                              return (
                                a.agent.metadata.namespace === agentNamespace &&
                                a.agent.metadata.name === agentName
                              );
                            }
                            // If no namespace specified, match by name only
                            return a.agent.metadata.name === agentName;
                          })

go/core/internal/controller/translator/agent/compiler.go:180

• Cycle/recursion errors are now detected using a kind-qualified key (agentStateKey), but the error messages still print only namespace/name, which can be ambiguous when an Agent and SandboxAgent share the same ref. Include the kind-qualified key in these messages for clarity.

	agentRef := utils.GetObjectRef(agent)
	spec := agent.GetAgentSpec()

	if state.isVisited(agentStateKey(agent)) {
		return fmt.Errorf("cycle detected in agent tool chain: %s -> %s", agentRef, agentRef)
	}

	if state.depth > MAX_DEPTH {
		return fmt.Errorf("recursion limit reached in agent tool chain: %s -> %s", agentRef, agentRef)
	}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.