Skip to content

fix(ui): fix model name editing on the model config form #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Valyrian-Code wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −2
Open

fix(ui): fix model name editing on the model config form #1979

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9bc962b
fix(ui): prevent model name edit pencil from submitting the form
Valyrian-Code Jun 8, 2026
1b4c046
Merge branch 'main' into fix/model-edit-name-button-type
Valyrian-Code Jun 8, 2026
59ecb37
fix(ui): make model name read-only when editing an existing model
Valyrian-Code Jun 8, 2026
b4b52cd
Merge branch 'main' into fix/model-edit-name-button-type
peterj Jun 11, 2026
e633b4c
Merge branch 'main' into fix/model-edit-name-button-type
peterj Jun 27, 2026
e35aa70
Merge branch 'main' into fix/model-edit-name-button-type
Valyrian-Code Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/components/models/new/BasicInfoSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export const BasicInfoSection: React.FC<BasicInfoSectionProps> = ({
</div>
)}
<Button
type="button"
data-test="edit-model-name-button"
variant="outline"
size="icon"
Expand Down
Loading