-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rack id #543
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the new config option for the start_link
API
https://github.com/kafka4beam/brod/pull/543/files#diff-bda931b0049203cab6d623157a37dea600ec29fce6fa9aaf2720cf25d5bca176R224
kpro_req_lib:fetch(Vsn, Topic, Partition, Offset, | ||
#{ max_wait_time => WaitTime | ||
, min_bytes => MinBytes | ||
, max_bytes => MaxBytes | ||
, isolation_level => IsolationLevel | ||
, rack_id => RackId | ||
}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kpro_req_lib:fetch(Vsn, Topic, Partition, Offset, | |
#{ max_wait_time => WaitTime | |
, min_bytes => MinBytes | |
, max_bytes => MaxBytes | |
, isolation_level => IsolationLevel | |
, rack_id => RackId | |
}). | |
kpro_req_lib:fetch(Vsn, Topic, Partition, Offset, | |
#{ max_wait_time => WaitTime | |
, min_bytes => MinBytes | |
, max_bytes => MaxBytes | |
, isolation_level => IsolationLevel | |
, rack_id => RackId | |
}). |
Hi @ditas |
|
Allow to provide rack id for kpro_req_lib:fetch/9 function