FE: Hide internal topics by default (closes #1073) #1412
+20
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No. Defaults only apply when the URL lacks
hideInternal
and no prior preference exists inlocalStorage
. Existing explicit URL values and saved preferences continue to work as before.What changes did you make? (Give an overview)
ListPage.tsx
): When the URL has nohideInternal
param, derive the value fromlocalStorage('hideInternalTopics')
, defaulting totrue
if missing.?hideInternal=true/false
).'true'
/'false'
) instead of truthy/falsy.URLSearchParams
instance (create a new one before callingsetSearchParams
).Closes #1073.
Is there anything you'd like reviewers to focus on?
'true'
) back tolocalStorage
on first run (current change does, for consistency across sessions).How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
No need to
Manually (IST):
localStorage
; open Topics →?hideInternal=true
gets appended.?hideInternal=false
in URL; list shows internals; reload preserves via URL/localStorage.Unit checks
Integration checks
Covered by existing automation
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
