Handle double proficiency and pace on skill and tool checks#124
Open
kaelad02 wants to merge 6 commits into
Open
Handle double proficiency and pace on skill and tool checks#124kaelad02 wants to merge 6 commits into
kaelad02 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do the double proficiency check to give advantage on skill and tool checks. The
doubleProfcheck is done in the roller to simplify the reminder class. I don't like the idea of passing both a skill and tool ID to do the check inside the roller.Add support for the travel pace too, when making certain skill checks from a party sheet. The question mark in
this.pace?is done so I don't have to adjust a bunch of unit tests.