Skip to content

Conversation

@alber70g
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Latest commit: 835997e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 7:11pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 7:11pm
preview-dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 7:11pm
proof-of-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 7:11pm
rwa-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 7:11pm
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 7:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
kode-ui ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 7:11pm

```

## Retrieve balance
If you haven't already downloaded and installed the `@kadena/client` libraries, see [Get started with Kadena client](/reference/kadena-client#get-started-with-kadena-client) for an introduction to creating and using client connections to interact with Chainweb nodes and the Kadena blockchain.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating and using client connections to interact with Chainweb nodes and the Kadena blockchain.

This seems confusing. Like there's a difference between chainweb nodes and the Kadena blockchain. They're the same thing.

Suggested change
If you haven't already downloaded and installed the `@kadena/client` libraries, see [Get started with Kadena client](/reference/kadena-client#get-started-with-kadena-client) for an introduction to creating and using client connections to interact with Chainweb nodes and the Kadena blockchain.
If you haven't already downloaded and installed the `@kadena/client` libraries, see [Get started with Kadena client](/reference/kadena-client#get-started-with-kadena-client) for an introduction to interact with the Kadena blockchain.

Comment on lines 62 to 65
If you haven't already downloaded and installed the `@kadena/client` libraries, see [Get started with Kadena client](/reference/kadena-client#get-started-with-kadena-client) for an introduction to creating and using client connections to interact with Chainweb nodes and the Kadena blockchain.
You should also download and install the helper utilities defined in the `@kadena/client-utils` library.
This library provides simplified functions for interacting with the Kadena `coin` contract and developing your own custom interfaces.
For more information about the helper utilities, see the [client-utils](https://github.com/kadena-community/kadena.js/tree/main/packages/libs/client-utils) repository and [@kadena/client-utils](https://www.npmjs.com/package/@kadena/client-utils) package registry.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to make this more concise. If they read to this section, they've already seen the code use @kadena/client.

Suggested change
If you haven't already downloaded and installed the `@kadena/client` libraries, see [Get started with Kadena client](/reference/kadena-client#get-started-with-kadena-client) for an introduction to creating and using client connections to interact with Chainweb nodes and the Kadena blockchain.
You should also download and install the helper utilities defined in the `@kadena/client-utils` library.
This library provides simplified functions for interacting with the Kadena `coin` contract and developing your own custom interfaces.
For more information about the helper utilities, see the [client-utils](https://github.com/kadena-community/kadena.js/tree/main/packages/libs/client-utils) repository and [@kadena/client-utils](https://www.npmjs.com/package/@kadena/client-utils) package registry.
Install `@kadena/client` (see [Get started with Kadena client](/reference/kadena-client#get-started-with-kadena-client)) and `@kadena/client-utils`, which simplifies interactions with Kadena's coin contract and custom interfaces. Documentation: [client-utils repo](https://github.com/kadena-community/kadena.js/tree/main/packages/libs/client-utils) or [npm package](https://www.npmjs.com/package/@kadena/client-utils).


The following example demonstrates how create, sign, and send a `transfer` transaction manually using the `@kadena/client` library:

```typescript
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to include other methods to sign the transaction as an alternative to signWithChainweaver.

I can imagine this will be very confusing when this doesn't work with wallet.kadena.io, or when we don't demonstrate the signWithKeypair: https://github.com/kadena-community/kadena.js/blob/main/packages/libs/client/src/signing/keypair/createSignWithKeypair.ts#L65-L93.

Caution

BTW, this is also not documented in the README.md of @kadena/client

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really confusing. I ran into massive problems signing transactions when I tried to update the election workshop to remove the signWithChainweaver function.
After a lot of monkeying around trying to make things work, the best I could do was brute force with a k: account and a generated key pair:

    const electionKeyPair:IKeyPair = {
      publicKey:
        "02b055c8be0eeaa659d0927f3e2399080c91f3fdf94d079498b04d6987acbd46",
      secretKey:
        '5a02489796c9ec2ec74edf15b63140224d0516ce6cd8f62303ac63b56a45c336',
    };

    const signWithKeypair = createSignWithKeypair([electionKeyPair]);
    const signedTx = await signWithKeypair(unsignedTransaction);

I'll put in whatever code you provide (maybe even some wallet adapter examples?), but it is frustrating to have examples that don't actually work.

Copy link
Contributor

@lsgunnlsgunn lsgunnlsgunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add some transaction signing examples.


The following example demonstrates how create, sign, and send a `transfer` transaction manually using the `@kadena/client` library:

```typescript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really confusing. I ran into massive problems signing transactions when I tried to update the election workshop to remove the signWithChainweaver function.
After a lot of monkeying around trying to make things work, the best I could do was brute force with a k: account and a generated key pair:

    const electionKeyPair:IKeyPair = {
      publicKey:
        "02b055c8be0eeaa659d0927f3e2399080c91f3fdf94d079498b04d6987acbd46",
      secretKey:
        '5a02489796c9ec2ec74edf15b63140224d0516ce6cd8f62303ac63b56a45c336',
    };

    const signWithKeypair = createSignWithKeypair([electionKeyPair]);
    const signedTx = await signWithKeypair(unsignedTransaction);

I'll put in whatever code you provide (maybe even some wallet adapter examples?), but it is frustrating to have examples that don't actually work.

@github-actions
Copy link
Contributor

This PR is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants