Skip to content

Conversation

@CBroz1
Copy link

@CBroz1 CBroz1 commented Apr 27, 2022

Depends on:

Added

  • Trial data files
  • ingestion functions first pass - needs testing bc element-interface version did not include allow_direct_insert arg
  • analysis.py script for downstream analysis - adjusted for attribute differences
  • fully functional notebooks except 04

Needs

  • integration tests - Nice to have
  • adjustment of scan time in analysis.py
  • verification of fake equipment data in notebooks/03

Note: I have the following in my .bash_profile to expedite jupytext process, which motivated the scripts/ -> py_scripts/ rename. We could adopt another convention.

alias jupysync='jupytext --sync notebooks/0*ipynb; mv notebooks/*py notebooks/py_scripts'

@CBroz1 CBroz1 marked this pull request as ready for review April 28, 2022 16:23
@CBroz1 CBroz1 marked this pull request as draft April 28, 2022 16:48
@CBroz1 CBroz1 marked this pull request as ready for review April 28, 2022 22:55
@kabilar kabilar merged commit de6438b into kabilar:main Apr 30, 2022
@kabilar
Copy link
Owner

kabilar commented Apr 30, 2022

Hi @CBroz1, just a heads up, I made the mistake of directly committing Thinh's suggestions to your fork/branch.

@kabilar
Copy link
Owner

kabilar commented Apr 30, 2022

Thank you for these updates, @CBroz1!

@kabilar
Copy link
Owner

kabilar commented Apr 30, 2022

I removed trial 50 since the start time occurred before trials 47-49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants