CI fix: switch flannel images from docker to quay.io #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to handle the rate limit of docker Signed-off-by: Sebastian Sch <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Merged
Pull Request Test Coverage Report for Build 12570289902Details
💛 - Coveralls |
adrianchiris
reviewed
Jan 7, 2025
| @@ -105,6 +105,43 @@ kcli create cluster generic --paramfile ./${cluster_name}-plan.yaml $cluster_nam | |||
| export KUBECONFIG=$HOME/.kcli/clusters/$cluster_name/auth/kubeconfig | |||
| export PATH=$PWD:$PATH | |||
|
|
|||
| # w/a switch flannel images to use quay repo to avoid dockerhub pull limit | |||
| # [SchSeba] there is a cronjob in place to make a copy of the image between dockerhub and quay account | |||
| ds=`kubectl -n kube-flannel get daemonset kube-flannel-ds -oyaml` | |||
There was a problem hiding this comment.
we already have a local registry set right ?
can we deploy k8s without flannel with kcli ?
i wonder if its better to build our own flannel image (make image) from a given release tag of the repo.
then reference it in the flannel ds and deploy. that way we dont rely on private repo (and cron job).
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle the rate limit of docker