Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v1.32.1-k3s1 and Go 1.23.4 #11620

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

rafaelbreno
Copy link
Contributor

No description provided.

Signed-off-by: Rafael Breno <[email protected]>
@rafaelbreno rafaelbreno requested a review from a team as a code owner January 16, 2025 14:25
Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you downgrading go?

@brandond
Copy link
Member

needs sign-off for dco

Signed-off-by: Rafael Breno <[email protected]>
@rafaelbreno rafaelbreno requested a review from cwayne18 January 16, 2025 16:51
@dereknola dereknola changed the title Update to v1.32.1-k3s1 and Go 1.22.10 Update to v1.32.1-k3s1 and Go 1.23.4 Jan 16, 2025
Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once DCO is signed

@rafaelbreno rafaelbreno merged commit 57f4a47 into k3s-io:release-1.32 Jan 16, 2025
38 checks passed
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.79%. Comparing base (9548f9b) to head (ded22e1).
Report is 1 commits behind head on release-1.32.

❗ There is a different number of reports uploaded between BASE (9548f9b) and HEAD (ded22e1). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (9548f9b) HEAD (ded22e1)
unittests 1 0
inttests 12 11
e2etests 9 8
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.32   #11620      +/-   ##
================================================
- Coverage         50.09%   42.79%   -7.30%     
================================================
  Files               185      167      -18     
  Lines             19265    18652     -613     
================================================
- Hits               9650     7982    -1668     
- Misses             8223     9338    +1115     
+ Partials           1392     1332      -60     
Flag Coverage Δ
e2etests 40.60% <ø> (-3.77%) ⬇️
inttests 35.15% <ø> (-0.07%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants