Fix DB resources error #593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB resources such as "rds_db_cluster" has a below error. "uninitialized constant Awspec::Type::RdsDBCluster" This error is caused by "dry-inflector" v1.1.0 update.
alexjfisher
reviewed
Jan 16, 2025
| @@ -24,7 +24,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_runtime_dependency 'addressable' | |||
| spec.add_runtime_dependency 'awsecrets', '~> 1' | |||
| spec.add_runtime_dependency 'aws-sdk', '~> 3' | |||
| spec.add_runtime_dependency 'dry-inflector' | |||
| spec.add_runtime_dependency 'dry-inflector', '>= 1.1' | |||
There was a problem hiding this comment.
Instead of requiring >= 1.1 we could require >= 0.1.2, (keeping support for older ruby versions), and then replace instances of Dry::Inflector.new in https://github.com/k1LoW/awspec/blob/7c19ade77e372bcc4a74bdfbbca85c030dcd1377/lib/awspec/ext/string.rb with
Dry::Inflector.new { |inflections| inflections.acronym 'DB' }It would add DB as an acronym to the older versions that didn't have it as a default. (Versions older than 0.1.2 don't support doing this.
There was a problem hiding this comment.
Unfortunately, there's no mechanism to remove a default as discussed here. dry-rb/dry-inflector#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB resources such as "rds_db_cluster" has a below error.
"uninitialized constant Awspec::Type::RdsDBCluster"
This error is caused by "dry-inflector" v1.1.0 update.