Fix projection formulas #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original projection formulas were incorrect. The updated ones are the ones used in OpenNI for projections, with two hardcoded constants that rely on sensor values; their derivation is described on the linked page.
|
Thanks for submitting this. Have you tested this projection with CAD-60 data? |
|
Unfortunately, I don't have all the libraries set up to run your code, but I have tested the formulas on CAD 120. I can try to set up the required libraries later but it may take a bit of time. Edited to add that these are the formulas for CAD 120, not CAD 60. |
|
@achalddave Thank you very much for this update, I was struggling with the old projections values. I am using CAD 120, with resolution 640x480. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.