Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit "Disconnect" event if an error occurred #299

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jwodder
Copy link
Owner

@jwodder jwodder commented Dec 12, 2023

Blocked by the need for zyansheep/rustyline-async#21 to be released.

To do:

  • Update rustyline-async requirement for whatever version the above fix is released in
  • Update THIRDPARTY.toml
  • Update CHANGELOG

@jwodder jwodder added the blocked Cannot be implemented until something else happens label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4010040) 82.78% compared to head (d7c27f6) 82.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   82.78%   82.85%   +0.06%     
==========================================
  Files           8        8              
  Lines         761      764       +3     
==========================================
+ Hits          630      633       +3     
  Misses        131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder self-assigned this Dec 12, 2023
@jwodder jwodder force-pushed the no-disconnect-on-err branch from 765c501 to d7c27f6 Compare December 13, 2023 23:08
@jwodder jwodder removed the blocked Cannot be implemented until something else happens label Dec 13, 2023
@jwodder jwodder marked this pull request as ready for review December 13, 2023 23:15
@jwodder jwodder merged commit 84a81fa into master Dec 13, 2023
21 checks passed
@jwodder jwodder deleted the no-disconnect-on-err branch December 13, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant